Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should ExtensionBlock.fillna unbox Series / Index? #22954

Open
TomAugspurger opened this issue Oct 2, 2018 · 1 comment
Open

Should ExtensionBlock.fillna unbox Series / Index? #22954

TomAugspurger opened this issue Oct 2, 2018 · 1 comment
Labels
Enhancement ExtensionArray Extending pandas with custom dtypes or arrays.

Comments

@TomAugspurger
Copy link
Contributor

values = self.values if inplace else self.values.copy()

Should we get the ExtensionArray / ndarray backing the Series / Index at that point? As an EA author, I'd rather not have to worry about extracting the extension array from a Series in my fillna.

In the ExtensionArray.fillna docstring, we say the type can be 'arraylike'.

@TomAugspurger TomAugspurger added the ExtensionArray Extending pandas with custom dtypes or arrays. label Oct 2, 2018
@jbrockmendel
Copy link
Member

ATM we cannot ensure that Block.fillna will not get a Series. #32420 fixes that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

No branches or pull requests

3 participants