Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API/DEPR: replace raise_conflict-kwarg in df.update with errors #23585

Closed
h-vetinari opened this issue Nov 8, 2018 · 0 comments · Fixed by #23657
Closed

API/DEPR: replace raise_conflict-kwarg in df.update with errors #23585

h-vetinari opened this issue Nov 8, 2018 · 0 comments · Fixed by #23657
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Deprecate Functionality to remove in pandas
Milestone
0.24.0

Comments

@h-vetinari
Copy link
Contributor

h-vetinari commented Nov 8, 2018 •
edited
Loading

From review in #23192:

pls create [an issue] to deprecate this arg and rename to errors=

The idea is to replace the raise_conflict=True|False with errors='ignore'|'raise'.

Same goes for Panel.
@h-vetinari h-vetinari changed the title API: replace raise_conflict-kwarg in update with errors API: replace raise_conflict-kwarg in df.update with errors Nov 8, 2018
@h-vetinari h-vetinari changed the title API: replace raise_conflict-kwarg in df.update with errors API/DEPR: replace raise_conflict-kwarg in df.update with errors Nov 8, 2018
@h-vetinari h-vetinari mentioned this issue Nov 9, 2018
Closed
4 tasks
@gfyoung gfyoung added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Deprecate Functionality to remove in pandas labels Nov 11, 2018
@h-vetinari h-vetinari mentioned this issue Nov 12, 2018
Merged
4 tasks
@jreback jreback added this to the 0.24.0 milestone Nov 14, 2018
@jsexauer jsexauer mentioned this issue Nov 14, 2018
Closed
1 task
@jreback jreback mentioned this issue Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

API/DEPR: replace "raise_conflict" with "errors" for df.update h-vetinari/pandas
3 participants
@jreback @gfyoung @h-vetinari