Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: code_checks patterns does not ignore .c files #24526

Closed
jreback opened this issue Jan 1, 2019 · 2 comments · Fixed by #24549
Closed

DOC: code_checks patterns does not ignore .c files #24526

jreback opened this issue Jan 1, 2019 · 2 comments · Fixed by #24549
Labels
CI Continuous Integration good first issue
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jan 1, 2019

should ignore .c files that are generated from .pyx (which are most)

get a bunch of errors like this

....
pandas/_libs/tslib.c:32200:Tailing whitespaces found:  * 
pandas/_libs/tslib.c:32201:Tailing whitespaces found:  * 
pandas/_libs/tslib.c:32211:Tailing whitespaces found:  * 
pandas/_libs/tslib.c:32213:Tailing whitespaces found:  * 
pandas/_libs/tslib.c:32214:Tailing whitespaces found:  * 
pandas/_libs/tslib.c:33594:Tailing whitespaces found:         
pandas/_libs/tslib.c:33595:Tailing whitespaces found:         
pandas/_libs/tslib.c:34701:Tailing whitespaces found:         
pandas/_libs/tslib.c:34702:Tailing whitespaces found:         
pandas/_libs/algos_take_helper.pxi:289:Tailing whitespaces found:     
pandas/_libs/algos_take_helper.pxi:324:Tailing whitespaces found:     
pandas/_libs/algos_take_helper.pxi:549:Tailing whitespaces found:     
pandas/_libs/algos_take_helper.pxi:584:Tailing whitespaces found:     
pandas/_libs/algos_take_helper.pxi:4709:Tailing whitespaces found:     
pandas/_libs/algos_take_helper.pxi:4744:Tailing whitespaces found:     
pandas.egg-info/PKG-INFO:10:Tailing whitespaces found: Description
pandas.egg-info/PKG-INFO:19:Tailing whitespaces found:         
pandas.egg-info/PKG-INFO:21:Tailing whitespaces found:         
pandas.egg-info/PKG-INFO:29:Tailing whitespaces found:         
pandas.egg-info/PKG-INFO:37:Tailing whitespaces found:         
pandas.egg-info/PKG-INFO:39:Tailing whitespaces found:         
pandas.egg-info/PKG-INFO:65:Tailing whitespaces found:         
pandas.egg-info/PKG-INFO:72:Tailing whitespaces found:         
Check that no file in the repo contains tailing whitespaces DONE
@jreback jreback added CI Continuous Integration good first issue labels Jan 1, 2019
@jreback jreback added this to the Contributions Welcome milestone Jan 1, 2019
@saurav2608
Copy link

@jreback - I will give this a shot.

@saurav2608
Copy link

saurav2608 commented Jan 1, 2019

@jreback - this error is generated from a section that Check that no file in the repo contains tailing whitespaces . Adding a exclusion for c (and cpp) files will prevent this errors for all c/cpp files in the repo and not just those generated from .pyx files. However, c/cpp files inside pandas/_libs are linted in another test. I believe adding exception should be okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants