Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API/ENH: Support/document/test fold argument in Timestamp #25057

Closed
mroeschke opened this issue Jan 31, 2019 · 0 comments · Fixed by #31563
Closed

API/ENH: Support/document/test fold argument in Timestamp #25057

mroeschke opened this issue Jan 31, 2019 · 0 comments · Fixed by #31563
Labels
API Design Datetime Datetime data dtype Timezones Timezone data dtype
Milestone

Comments

@mroeschke
Copy link
Member

Python 3.6 added a fold argument in datetime.datetime to disambiguate DST transition times that occur twice (in wall time).

https://docs.python.org/3/library/datetime.html#datetime-objects.

Technically Timestamp will accept the argument in 3.6, but it's not formally documented or tested.
Additionally since we will still be supporting 3.5 after dropping 2.7, we can add/handle a fold argument directly in the Timestamp constructor as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Datetime Datetime data dtype Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants