Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excluding validation error type PR10 from code base #25104

Closed
2 tasks
stijnvanhoey opened this issue Feb 3, 2019 · 1 comment
Closed
2 tasks

Excluding validation error type PR10 from code base #25104

stijnvanhoey opened this issue Feb 3, 2019 · 1 comment
Labels
Docs
Milestone
0.25.0

Comments

@stijnvanhoey
Copy link
Contributor

stijnvanhoey commented Feb 3, 2019 •
edited
Loading

Problem description

In order to have a continuous check by the CI on validation error PR10, tackling them from the current code base enables the addition to the CI for automated testing in the future.

After checking an overview of the errors (all credits to @datapythonista for the introduction during europandas sprint), the PR10 has just 3 occurrences, so tackling them should be feasible during the sprint.

deprecated section type
pandas.set_option 0 Working with options CallableDynamicDoc
pandas.ExcelWriter 0 ABCMeta
pandas.core.groupby.DataFrameGroupBy.boxplot 0 Computations / Descriptive Stats function

Todo:

  • get rid of the errors in the code base
  • update the code_check.sh script to take into account the PR10 type of errors
@victormoron
Copy link
Contributor

I'll take it

@victormoron victormoron mentioned this issue Feb 3, 2019
Merged
@jreback jreback added the Docs label Feb 3, 2019
@jreback jreback added this to the 0.25.0 milestone Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.25.0
Development

No branches or pull requests
3 participants
@stijnvanhoey @jreback @victormoron