Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings in template for intervaltree.pxi #27169

Closed
ghost opened this issue Jul 1, 2019 · 0 comments · Fixed by #30560
Closed

Build warnings in template for intervaltree.pxi #27169

ghost opened this issue Jul 1, 2019 · 0 comments · Fixed by #30560
Labels
Build Library building on various platforms Interval Interval data type
Milestone

Comments

@ghost
Copy link

ghost commented Jul 1, 2019

The scalar_t fused type

ctypedef fused scalar_t:
float64_t
float32_t
int64_t
int32_t
uint64_t
mixes signed and unsigned types. Later on, the code does comparisons with unsigned types, which creates a bunch of compiler warning.

xref http://docs.cython.org/en/latest/src/userguide/fusedtypes.html#type-checking-specializations

From comments in #27157 it appears there's no established guideline on how different cases for different types should look like in the templates. That's a hindrance to fixing this (and other warnings) as well.

@jschendel jschendel added Build Library building on various platforms Interval Interval data type labels Jul 2, 2019
@jschendel jschendel added this to the Contributions Welcome milestone Jul 2, 2019
@ghost ghost changed the title Build warnings in interval* cython Build warnings in template for intervaltree.pxi Jul 2, 2019
@jreback jreback modified the milestones: Contributions Welcome, 1.0 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Interval Interval data type
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants