Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RLS: 1.0.0 #27492

Closed
jreback opened this issue Jul 20, 2019 · 26 comments
Closed

RLS: 1.0.0 #27492

jreback opened this issue Jul 20, 2019 · 26 comments
Labels
Release
Milestone
1.0.0

Comments

@jreback
Copy link
Contributor

jreback commented Jul 20, 2019

discussion for 1.0.

We are focusing all deprecation removals and we should try to release by September 2019.
@jreback jreback added this to the 1.0 milestone Jul 20, 2019
@jbrockmendel
Copy link
Member

duplicate of #17287

@jreback
Copy link
Contributor Author

jreback commented Jul 20, 2019

not a duplicate

the other issue is a wish list

@simonjayhawkins
Copy link
Member

We are focusing all deprecation removals

does this start now, or after 0.25.1, 0.25.2?

@jreback
Copy link
Contributor Author

jreback commented Jul 21, 2019

yes removals start now for 1.0

@simonjayhawkins
Copy link
Member

also, are we dropping Python 3.5 for 1.0? and moving to inline variable annotations?

@jreback
Copy link
Contributor Author

jreback commented Jul 21, 2019

yes to both (need to drop 3.5 first of course)

@simonjayhawkins
Copy link
Member

cool.

3.8.0 final: Monday, 2019-10-21, so after pandas 1.0, shouldn't need to backport 3.8 issues to 0.25, but will probably need to backport 3.8 issues to 1.0.

at some point before the 1.0 release, we'll probably need PY3.8 builds against either the betas or RCs

@simonjayhawkins simonjayhawkins mentioned this issue Jul 25, 2019
Merged
@simonjayhawkins simonjayhawkins mentioned this issue Sep 13, 2019
Merged
@WillAyd
Copy link
Member

WillAyd commented Sep 18, 2019

We don't have a list of removals we need to make here yet right? I assume it's most everything in #18262 and maybe more. Happy to open a new issue for that if not done already and track therein (or here as well)

@jorisvandenbossche
Copy link
Member

I assume it's most everything in #18262

That issue is for things we want to deprecate, not necessarily for things to remove. Up to now, we have been using this issue to keep track of that: #6581
In principle everything in that list should be removed (maybe with priority for the older ones)

@TomAugspurger TomAugspurger mentioned this issue Oct 16, 2019
Closed
@TomAugspurger
Copy link
Contributor

cc @pandas-dev/pandas-core it's about time to cut a release candidate. I'd like to do one on Friday / this weekend if possible, and let it sit for a week or two. Does that sound reasonable to people? I'll go through the backlog of issues / PRs tagged for 1.0, but let me know if you have an issue you consider a blocker and I'll add it to the list.

@jreback
Copy link
Contributor Author

jreback commented Dec 30, 2019

cc @pandas-dev/pandas-core it's about time to cut a release candidate. I'd like to do one on Friday / this weekend if possible, and let it sit for a week or two. Does that sound reasonable to people? I'll go through the backlog of issues / PRs tagged for 1.0, but let me know if you have an issue you consider a blocker and I'll add it to the list.

sgtm. i don't think we have anything actually blocking, just a couple of PRs (NA stuff) that should merge before, but seems doable.

@jorisvandenbossche
Copy link
Member

Would targetting the end of next week instead of this week also be OK? (or a few days earlier, if ready)

I would personally prefer that. There have been merged quite some substantial changes the last days / still need to be merged today/tomorrow, and I think it would be good to have those at least a few days in master (and in a week that more people are active. I am myself still mostly offline until the end of this week).

@TomAugspurger
Copy link
Contributor

That’s reasonable. I won’t have much time today either.

@TomAugspurger
Copy link
Contributor

We also have our dev meeting on Wednesday. I think we may want to discuss branching things and what we’ll consider merging to master during the RC period. So let’s plan for Wednesday afternoon.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jan 9, 2020 •
edited
Loading

@pandas-dev/pandas-core If there aren't any objections, I'd like to tag the RC at around 2:00 Central (~6 hours from now). What PRs / issues should be considered blockers (feel free to add to the list)?

@TomAugspurger
Copy link
Contributor

OK, tagging the RC.

@TomAugspurger
Copy link
Contributor

Tagged, and have started a 1.0.x maintenance branch. Merges to master with the 1.0.0 milestone will be backported to that branch.

Binaries are building.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jan 10, 2020 •
edited
Loading

@cgohlke Not sure if you typically build wheels for RCs, but if you do we've tagged 1.0.0rc0: https://github.com/pandas-dev/pandas/releases/download/v1.0.0rc0/pandas-1.0.0rc0.tar.gz

Edit: they're up now. Thanks!

@topper-123
Copy link
Contributor

I know it's not super-critical, but could we backport type hint related PR's to 1.0? I'm thinking especially about #30761 and #30947, both of which are currently tagged for 1.1. There could of course be other.

The rationale is especially:

  • Type hints give a better user experience for users with IDEs (PyCharm etc.)
  • a very low (or no) risk of breakage, because it's just type hint, not code.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Jan 22, 2020 •
edited
Loading

I don't have strong thoughts on backporting the typing PRs. My initial preference is to not backport them, but it's not a strong feeling.

@pandas-dev/pandas-core what do people think about targeting 1.0.0 for early next week, perhaps Tuesday the 28th? Add / modify this list as you see fit.

https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.0.0

Blockers / Regressions

Nice to have

Unsure (move these to where you think they should be)

@TomAugspurger
Copy link
Contributor

@pandas-dev/pandas-core I'm hoping to do the release today. The only potential blocker is #31359, but that's a bit tricky. It's not clear what the best way forward is there (chime in there if you have thoughts).

Is there any objection to also pushing the new website to pandas.pydata.org at the same time?

@TomAugspurger
Copy link
Contributor

OK, tagging it!

@TomAugspurger TomAugspurger modified the milestones: 1.0.0, 1.0.1 Jan 29, 2020
@TomAugspurger TomAugspurger added this to the 1.0.0 milestone Jan 29, 2020
@TomAugspurger
Copy link
Contributor

Conda packages are up in defaults and conda-forge. Just waiting on windows wheels, then I'll send out the announcement.

@TomAugspurger
Copy link
Contributor

Binaries are up, and sent out the announcement.

Congrats everyone!

@jorisvandenbossche
Copy link
Member

Thanks a lot, Tom !

@jreback
Copy link
Contributor Author

jreback commented Jan 30, 2020

thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Release
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
7 participants
@WillAyd @jreback @jorisvandenbossche @TomAugspurger @jbrockmendel @simonjayhawkins @topper-123