Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: centrailize _check_percentile #27559

Closed
jreback opened this issue Jul 24, 2019 · 1 comment · Fixed by #27584
Closed

CLN: centrailize _check_percentile #27559

jreback opened this issue Jul 24, 2019 · 1 comment · Fixed by #27584
Labels
Clean good first issue Refactor Internal refactoring of code
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jul 24, 2019

we use _check_percentile in a couple of places; its a method on the NDFrame which is not needed, refactor to move it to pandas/core/algorithms.py (near quantile).

pandas/core/generic.py:            self._check_percentile(percentiles)
pandas/core/generic.py:    def _check_percentile(self, q):
pandas/core/series.py:        self._check_percentile(q)
pandas/core/frame.py:        self._check_percentile(q)

there is another reference in groupby added here: #27473; change the validation logic to call this function as well (likely the call will need to be in the quantile call to groupby (pandas/core/groupby/groupby.py)

@jreback jreback added the Refactor Internal refactoring of code label Jul 24, 2019
@jreback jreback added this to the 1.0 milestone Jul 24, 2019
@hedonhermdev
Copy link
Contributor

Can I work on this issue?

@jreback jreback modified the milestones: 1.0, 0.25.1 Jul 25, 2019
@TomAugspurger TomAugspurger modified the milestones: 0.25.1, 1.0 Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean good first issue Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants