Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type annotations are inconsistent for 'columns' in IO methods #30449

Open
ShaharNaveh opened this issue Dec 24, 2019 · 3 comments
Open

Type annotations are inconsistent for 'columns' in IO methods #30449

ShaharNaveh opened this issue Dec 24, 2019 · 3 comments
Labels
API - Consistency Internal Consistency of API/Behavior Typing type annotations, mypy/pyright type checking

Comments

@ShaharNaveh
Copy link
Member

ShaharNaveh commented Dec 24, 2019 •
edited

@ShaharNaveh ShaharNaveh changed the title Type annotatins for 'columns' Type annotatins are incontinence for 'columns' Dec 24, 2019
@ShaharNaveh ShaharNaveh changed the title Type annotatins are incontinence for 'columns' Type annotatins are incontinence for 'columns' in IO methods Dec 24, 2019
@alimcmaster1 alimcmaster1 added the Typing type annotations, mypy/pyright type checking label Dec 24, 2019
@jbrockmendel
Copy link
Member

incontinence -> inconsistent?

@ShaharNaveh
Copy link
Member Author

incontinence -> inconsistent?

Yes! incontinence sounded wrong, but I couldn't figure out why, but now I know why.

@ShaharNaveh ShaharNaveh changed the title Type annotatins are incontinence for 'columns' in IO methods Type annotatins are inconsistent for 'columns' in IO methods Dec 24, 2019
@jbrockmendel
Copy link
Member

ok good, otherwise that would have been an exceptionally high-priority issue to address

@jbrockmendel jbrockmendel added the API - Consistency Internal Consistency of API/Behavior label Dec 25, 2019
@simonjayhawkins simonjayhawkins changed the title Type annotatins are inconsistent for 'columns' in IO methods Type annotations are inconsistent for 'columns' in IO methods Dec 28, 2019
@ShaharNaveh ShaharNaveh mentioned this issue Jan 2, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API - Consistency Internal Consistency of API/Behavior Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbrockmendel @alimcmaster1 @ShaharNaveh