Multi Phase JSON Initialization #30805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Jan 8, 2020
| NULL, /* m_clear */ | ||
| NULL /* m_free */ | ||
| static PyModuleDef moduledef = { | ||
| .m_base = PyModuleDef_HEAD_INIT, |
There was a problem hiding this comment.
Designated initializers are C99 standard and supported by MS since Visual Studio 2013. Orthogoanl here but I figured made things more readable and less verbose
|
sure |
This was referenced Jul 25, 2020
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature in Python 3.5 that should simplify instantiation of the JSON module and make it more "pythonic"
https://docs.python.org/3/c-api/module.html?highlight=multi%20phase#multi-phase-initialization
https://www.python.org/dev/peps/pep-0489/
Also removed a version string from within the extension, as I don't see where that is useful