BUG: Increased support for subclassed types. #31331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 26, 2020 12:24
|
|
||
| df = tm.SubclassedDataFrame({"A": [1, 2, 3], "B": [4, 5, 6], "C": [7, 8, 9]}) | ||
| result = df.idxmax() | ||
| assert isinstance(result, tm.SubclassedSeries) |
There was a problem hiding this comment.
this looks like it can be parametrized+shared with test_idxmin. if there are any others that can be parametrized, pls give it a try
|
@EmilianoJordan still active? Can you fix up and get green? |
added 7 commits
April 17, 2020 16:44
# Conflicts: # doc/source/whatsnew/v1.1.0.rst # pandas/core/frame.py
…g on scipy import.
jreback
added
the
Compat
jreback
requested changes
Apr 21, 2020
jreback
approved these changes
May 10, 2020
|
thanks @EmilianoJordan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff