Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: do all convert_tolerance casting inside Index.get_loc #31425

Merged
merged 6 commits into from
Feb 1, 2020
Merged

REF: do all convert_tolerance casting inside Index.get_loc #31425

merged 6 commits into from
Feb 1, 2020

Conversation

jbrockmendel
Copy link
Member

As a bonus we get better exception messages in the affected tests.

@jbrockmendel jbrockmendel added the Indexing Related to indexing on series/frames, not to indexes themselves label Jan 29, 2020
@jreback jreback added the Timedelta Timedelta data type label Jan 31, 2020
@jreback jreback added this to the 1.1 milestone Jan 31, 2020
@jreback
Copy link
Contributor

jreback commented Jan 31, 2020

is this actually a bug fix? e.g.the error message before was ints and not its (correctly) timestamps.?

@jbrockmendel
Copy link
Member Author

e.g.the error message before was ints and not its (correctly) timestamps.?

I guess so, sure

@WillAyd
Copy link
Member

WillAyd commented Jan 31, 2020

lgtm ex merge conflict

@jbrockmendel
Copy link
Member Author

rebased+green

@jbrockmendel
Copy link
Member Author

added whatsnew for improved exception messages, rebased+green

@jreback jreback merged commit 07eda6a into pandas-dev:master Feb 1, 2020
@jreback
Copy link
Contributor

jreback commented Feb 1, 2020

ok!

@jbrockmendel jbrockmendel deleted the convert_tolerance branch February 1, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Timedelta Timedelta data type
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jbrockmendel @jreback @WillAyd