Disallow .__call__() as workaround for non-named functions #32460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Mar 15, 2020
jreback
added
Error Reporting
|
It's not about lambdas. In this context "named" means a variable name or an attribute - pandas doesn't allow calling arbitrary expressions. For example |
alexmojaki
force-pushed
the
disallow-call
branch
2 times, most recently
from
0a3a36d
to
f8fe5ff
Compare
jreback
requested changes
Apr 10, 2020
|
|
||
| df.eval("@func()") | ||
|
|
||
| with pytest.raises(TypeError): |
There was a problem hiding this comment.
can you test the exception message as well, it is not clear what the user is going to see here
|
@jreback ping! |
jreback
requested changes
May 10, 2020
| @@ -1181,3 +1181,17 @@ def test_failing_character_outside_range(self, df): | |||
| def test_failing_hashtag(self, df): | |||
| with pytest.raises(SyntaxError): | |||
| df.query("`foo#bar` > 4") | |||
|
|
|||
| def test_call_non_named_expression(self, df): | |||
| def func(*_): | |||
There was a problem hiding this comment.
can you add the issue number here as a comment.
|
Hello @alexmojaki! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-05-10 17:52:29 UTC |
|
@jreback pong! |
jreback
approved these changes
May 13, 2020
|
thanks @alexmojaki |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this script:
Fails with:
however this can easily be worked around by adding
.__call__:I'm assuming we don't want to allow this workaround. This PR ensures that it will fail with the same error.