ENH: IntegerArray.astype(dt64) #32538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By my count, after today's slew of values_from_object/internal_get_values PRs, we'll have
(not counting usages in tests, docstrings, or in the each other's implementations) |
…_datetime-no-mask
…_datetime-no-mask
…_datetime-no-mask
jreback
added
Dtype Conversions
jreback
reviewed
Mar 11, 2020
| @@ -633,6 +633,15 @@ def test_astype_specific_casting(self, dtype): | |||
| expected = pd.Series([1, 2, 3, None], dtype=dtype) | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| def test_astype_dt64(self): | |||
There was a problem hiding this comment.
do we have tests with None, np.nan here as well?
There was a problem hiding this comment.
i guess those would go in the test for pd.array inference in tests.arrays.test_array, where I see a test for [1, None]
…_datetime-no-mask
…_datetime-no-mask
Closed
|
thanks. can you add a release note in a followon. (I guess this is a bug fix) |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffLet's us de-kludge to_datetime code, getting rid of another _ndarray_values usage.