Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Series.__setitem__[listlike_of_integers] with IntervalIndex #33473

Merged
merged 18 commits into from
Apr 17, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 11, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jbrockmendel jbrockmendel changed the title BUG: Series.__setitem__[listlike_of_integers] with IntervalIndex] BUG: Series.__setitem__[listlike_of_integers] with IntervalIndex Apr 11, 2020
@gfyoung gfyoung added Bug Indexing Related to indexing on series/frames, not to indexes themselves labels Apr 12, 2020
@gfyoung
Copy link
Member

gfyoung commented Apr 12, 2020

Changes make sense. Just needs a whatsnew I think.

@jreback jreback added this to the 1.1 milestone Apr 12, 2020
@jreback
Copy link
Contributor

jreback commented Apr 12, 2020

yep if you can add a whatsnew

@jbrockmendel
Copy link
Member Author

updated with whatsnew

@jbrockmendel
Copy link
Member Author

updated + green (finally)

@mroeschke mroeschke merged commit f11fb8c into pandas-dev:master Apr 17, 2020
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the fallback2 branch April 17, 2020 19:44
CloseChoice pushed a commit to CloseChoice/pandas that referenced this pull request Apr 20, 2020
…das-dev#33473)

* BUG: Series.__getitem__ with MultiIndex and leading integer level

* dedicated tests

* whatnsew

* test

* REF: collect DataFrame.__setitem__ tests (pandas-dev#33408)

* use https link for Anaconda (pandas-dev#33413)

* unpinned 37 (pandas-dev#33423)

* revert

* BUG: Series.__setitem__[listlike_of_integers] with IntervalIndex]

* whatsnew

Co-authored-by: partev <petrosyan@gmail.com>
Co-authored-by: William Ayd <will_ayd@innobi.io>
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
…das-dev#33473)

* BUG: Series.__getitem__ with MultiIndex and leading integer level

* dedicated tests

* whatnsew

* test

* REF: collect DataFrame.__setitem__ tests (pandas-dev#33408)

* use https link for Anaconda (pandas-dev#33413)

* unpinned 37 (pandas-dev#33423)

* revert

* BUG: Series.__setitem__[listlike_of_integers] with IntervalIndex]

* whatsnew

Co-authored-by: partev <petrosyan@gmail.com>
Co-authored-by: William Ayd <will_ayd@innobi.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants