Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Series[listlike_of_ints] incorrect on MultiIndex #33539

Merged
merged 12 commits into from
Apr 25, 2020
Merged

BUG: Series[listlike_of_ints] incorrect on MultiIndex #33539

merged 12 commits into from
Apr 25, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 14, 2020 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This is one of the cases that @jorisvandenbossche identified in #33355.

jbrockmendel and others added 8 commits April 10, 2020 16:15
@jbrockmendel jbrockmendel added Bug Indexing Related to indexing on series/frames, not to indexes themselves labels Apr 14, 2020
jreback
jreback requested changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a section in api breaking changes with an example as its possible some people were actually relying on this. i don't think deprecation is warranted as this is a small edge case.

@jbrockmendel
Copy link
Member Author

whatsnew added + green

@jbrockmendel
Copy link
Member Author

rebased+green

@jreback jreback added this to the 1.1 milestone Apr 25, 2020
@jreback jreback merged commit c6a1638 into pandas-dev:master Apr 25, 2020
@jbrockmendel jbrockmendel deleted the fallback3 branch April 25, 2020 21:22
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
@jbrockmendel @rhshadrach
BUG: Series[listlike_of_ints] incorrect on MultiIndex (pandas-dev#33539)
99087c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbrockmendel @jreback @cleconte987 @ShaharNaveh