Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG/API: getitem behavior with list match ndarray/index/series #33646

Merged
merged 4 commits into from
Apr 19, 2020
Merged

BUG/API: getitem behavior with list match ndarray/index/series #33646

merged 4 commits into from
Apr 19, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Apr 19, 2020 •
edited
Loading

mroeschke
mroeschke reviewed Apr 19, 2020
View reviewed changes
pandas/tests/series/indexing/test_getitem.py Outdated
@@ -78,6 +78,18 @@ def test_getitem_median_slice_bug(self):


class TestSeriesGetitemListLike:
@pytest.mark.parametrize("box", [list, np.array, pd.Index, pd.Series])
def test_getitem_no_matches(self, box):
# GH#33462 we expect the same behavior for list/ndarray/Index/Serioes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Serioes -> Series

mroeschke
mroeschke approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this closes #33642 instead (the OP references the pull request for some reason)

@jbrockmendel
Copy link
Member Author

updated, thanks

@jreback jreback added Bug Indexing Related to indexing on series/frames, not to indexes themselves labels Apr 19, 2020
@jreback jreback added this to the 1.1 milestone Apr 19, 2020
@jreback jreback merged commit 56d0934 into pandas-dev:master Apr 19, 2020
@jreback
Copy link
Contributor

jreback commented Apr 19, 2020

thanks

@jbrockmendel jbrockmendel deleted the 33642 branch April 19, 2020 21:30
CloseChoice pushed a commit to CloseChoice/pandas that referenced this pull request Apr 20, 2020
@jbrockmendel @CloseChoice
BUG/API: getitem behavior with list match ndarray/index/series (panda…
2372bce 
…s-dev#33646)
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
@jbrockmendel @rhshadrach
BUG/API: getitem behavior with list match ndarray/index/series (panda…
f068e3f 
…s-dev#33646)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

API: Series[index_with_no_matches] vs Series[list_with_no_matches]
3 participants
@jbrockmendel @jreback @mroeschke