Make option_context a ContextDecorator. #34253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
approved these changes
May 19, 2020
|
Can you merge master and repush? Should get CI green |
|
done |
jreback
requested changes
May 20, 2020
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -236,6 +236,7 @@ Other enhancements | |||
| and :class:`~pandas.io.stata.StataWriterUTF8` (:issue:`26599`). | |||
| - :meth:`HDFStore.put` now accepts `track_times` parameter. Parameter is passed to ``create_table`` method of ``PyTables`` (:issue:`32682`). | |||
| - Make :class:`pandas.core.window.Rolling` and :class:`pandas.core.window.Expanding` iterable（:issue:`11704`) | |||
| - Make ``option_context`` a :class:`contextlib.ContextDecorator`, which allows it to be used as a decorator over an entire function. | |||
There was a problem hiding this comment.
can you add this PR number as the issue number
| @@ -410,6 +410,12 @@ def eq(val): | |||
| self.cf.set_option("a", 17) | |||
| eq(17) | |||
|
|
|||
| @self.cf.option_context("a", 123) | |||
There was a problem hiding this comment.
can you add a comment with this issue number here (and a comment on what we are testing here)
This makes it possible to use option_context as a decorator over an entire function, saving an indent level and making it easy to comment out (or in) the context while keeping correct indentation.
jreback
approved these changes
May 25, 2020
|
thanks @anntzer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use option_context as a decorator over an
entire function, saving an indent level and making it easy to comment
out (or in) the context while keeping correct indentation.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff