-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: validate limit_direction
parameter of NDFrame.interpolate
#34746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test currently only test `limit_area`. For `limit_direction` the implementation should later raise an error, because `pad` and `bfill` both already define a direction. But let's now first do the implementation of the `limit_area` for `pad` and `bfill`.
Since methods `pad` and `bfill` in `blocks.interpolate` end up using `missing.interpolate_2d` which can not (easily) be extended to support `limit_area`, I introduce the new function `missing.interpolate_1d_fill`. It is a modified copy of `interpolate_2d` but only works for 1d data and uses newly introduced function `_derive_indices_of_nans_to_preserve`, which is now also used in `missing.interpolate_1d`. It works the same way as the 1D-interpolation functions which are based on scipy-interpolation which are applied via np.apply_along_axis.
…values` also was changed via appliying `func`
…e used Test for all forbidden combos of `pad` and `backfill` is included
…d `limit_direction`
…ments Test on my local machine are not affected by removing the unncessery arguments `valid` and `invalid`, which are now derived within the function.
…imit_area_and_limit_direction_with_pad Manually resolved conflicts: * doc/source/whatsnew/v1.1.0.rst: Just a conflicting line * pandas/tests/series/test_missing.py: All test for interpolation have been moved to a new file pandas/tests/series/methods/test_interpolate.py I accepted all changes from upstream, which removed my tests from test_missing.py and manually added my test to the new file methods/test_interpolate.py
Co-Authored-By: William Ayd <william.ayd@icloud.com>
…imit_area_and_limit_direction_with_pad
…imit_area_and_limit_direction_with_pad
WillAyd
approved these changes
Jun 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
5 tasks
can you rebase, otherwise lgtm. |
rebased + green |
thanks @simonjayhawkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
broken off #31048