New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pandas.core.generic.NDFrame.to_replace() to appease static type analysis #34898
Comments
Can you share the errors you were seeing? |
jbrockmendel
added
Refactor
Internal refactoring of code
replace
replace method
Typing
type annotations, mypy/pyright type checking
labels
Jun 23, 2020
oguzhanogreden
changed the title
Refactor pandas.core.to_replace() to appease static type analysis
Refactor pandas.core.Series.to_replace() to appease static type analysis
Jun 26, 2020
oguzhanogreden
changed the title
Refactor pandas.core.Series.to_replace() to appease static type analysis
Refactor pandas.core.generic.NDFrame.to_replace() to appease static type analysis
Jun 26, 2020
For instance, here mypy would complain that I specified Here's the relevant mypy output (line numbers don't agree with upstream):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current implementation of
pandas.core.to_replace()
method won't allow type hints, as noted in #32542 . Contributor guidelines suggest a refactor in this case.The text was updated successfully, but these errors were encountered: