-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix styler cell_ids arg so that blank style is ignored on False #35588
Conversation
Can you add a test case for the problem you are trying to solve? As reviewers this is typically the first thing we look for |
Do you mean in the issue or a test in code?
yields...
This is clearly erroneous since it has added the id tag to every data cell when (0,0) and (1,1) should be ignored. Note that the correct output was produced using the same code on pandas version 1.0.4. The bug fix in this PR yields the code:
which restores correct functionality since the id tags are removed where appropriate. |
@attack68 in the code - see the contributing guide https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#test-driven-development-code-writing
|
I wrote what I thought was a very simple test, demonstrating the issue and impact, in the necessary format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a whatsnew note (1.1.1) is ok, put in bug fix section (not regressions)
New test failures appeared after the merge by simon. These seem unrelated to my code changes. Any advice? |
thanks @attack68 |
@meeseeksdev backport to 1.1.x |
…ank style is ignored on False
…is ignored on False (#35619) Co-authored-by: attack68 <24256554+attack68@users.noreply.github.com>
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff