Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGR: follow-up to return copy with df.interpolate on empty DataFrame #35774

Merged
merged 3 commits into from Aug 18, 2020
Merged

REGR: follow-up to return copy with df.interpolate on empty DataFrame #35774

merged 3 commits into from Aug 18, 2020

Conversation

simonjayhawkins
Copy link
Member

follow-up to #35543

@simonjayhawkins simonjayhawkins added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Regression Functionality that used to work in a prior pandas version labels Aug 17, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1.1 milestone Aug 17, 2020
@simonjayhawkins
Copy link
Member Author

do we want to test this explicitly in this case

@jreback
Copy link
Contributor

jreback commented Aug 17, 2020

do we want to test this explicitly in this case

sure could add a test

@simonjayhawkins
Copy link
Member Author

@jreback OK to merge (and backport)

@jreback jreback merged commit 66e83cc into pandas-dev:master Aug 18, 2020
@jreback
Copy link
Contributor

jreback commented Aug 18, 2020

thanks. I still don't tihink this is actually the correct place to do this (as it should be handled gracefully in the internal interpolate), but not a blocker.

@simonjayhawkins
Copy link
Member Author

@meeseeksdev backport 1.1.x

@meeseeksmachine meeseeksmachine mentioned this pull request Aug 18, 2020
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 18, 2020
@simonjayhawkins @meeseeksmachine
Backport PR pandas-dev#35774: REGR: follow-up to return copy with df.…
5506bf0 
…interpolate on empty DataFrame
@simonjayhawkins simonjayhawkins deleted the followup branch August 18, 2020 13:06
simonjayhawkins added a commit that referenced this pull request Aug 18, 2020
@meeseeksmachine @simonjayhawkins
Backport PR #35774: REGR: follow-up to return copy with df.interpolat…
4fc0330 
…e on empty DataFrame (#35789)

Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonjayhawkins @jreback