Changed 'int' type to 'integer' in to_numeric docstring #35776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @edwardkong. The docstring for SparseArray also seems to've been changed in error by the same PR, can you fix that here also? |
simonjayhawkins
requested changes
Aug 18, 2020
There was a problem hiding this comment.
Thanks @edwardkong for the PR. lgtm ex @dsaxton comment
can you also revert the changes to pandas/core/arrays/sparse/array.py made in #33093
|
i'll add this to the 1.1.1 milestone as effectively a regression in the docs. feel free to change if disagree |
Thanks @edwardkong Since I want to make sure this is fixed for 1.1.1 I pushed this change. |
|
@jreback ok to merge (and backport) |
simonjayhawkins
approved these changes
Aug 19, 2020
jreback
requested changes
Aug 19, 2020
jreback
approved these changes
Aug 19, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 19, 2020
…umeric docstring
|
Thanks @edwardkong |
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 19, 2020
…string (#35806) Co-authored-by: edwardkong <33737404+edwardkong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff