BUG: item_cache invalidation in get_numeric_data #35882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-get_numeric_data
…g-get_numeric_data
…g-get_numeric_data
WillAyd
requested changes
Aug 26, 2020
| @@ -191,6 +191,23 @@ def test_corr_nullable_integer(self, nullable_column, other_column, method): | |||
| expected = pd.DataFrame(np.ones((2, 2)), columns=["a", "b"], index=["a", "b"]) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_corr_item_cache(self): | |||
| # Check that corr does not lead to incorrect entries in item_cache | |||
There was a problem hiding this comment.
Is there an open issue for this? If not can you add a whatsnew?
…g-get_numeric_data
…g-get_numeric_data
…g-get_numeric_data
…g-get_numeric_data
jreback
requested changes
Sep 5, 2020
| @@ -719,7 +719,6 @@ def get_numeric_data(self, copy: bool = False) -> "BlockManager": | |||
| copy : bool, default False | |||
| Whether to copy the blocks | |||
| """ | |||
| self._consolidate_inplace() | |||
There was a problem hiding this comment.
if you are removing this then get_bool_data right above looks suspicious.
There was a problem hiding this comment.
i agree. thats part of the _reduce trouble we discussed this afternoon. #34918 removes that usage.
jreback
approved these changes
Sep 5, 2020
|
thanks @jbrockmendel |
|
whatsnew in 1.1.2. should this be backported and milestone changed or release note moved? in release readiness I now check whatsnew on master and backport in sync https://github.com/simonjayhawkins/pandas-release/runs/1078142445?check_suite_focus=true |
Closed
|
@meeseeksdev backport 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 7, 2020
jreback
pushed a commit
that referenced
this pull request
Sep 7, 2020
…36188) Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Sep 8, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff