Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API/BUG: NumericIndex.insert(1, bool) should raise instead of cast #36319

Closed
jbrockmendel opened this issue Sep 13, 2020 · 0 comments · Fixed by #38030
Closed

API/BUG: NumericIndex.insert(1, bool) should raise instead of cast #36319

jbrockmendel opened this issue Sep 13, 2020 · 0 comments · Fixed by #38030
Labels
API Design Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
Casting Consistency
Milestone
1.2

Comments

@jbrockmendel
Copy link
Member

There are a bunch of setitem-like methods and we should try to be consistent in what we allow in them. In particular, Float64Index.putmask will reject a bool value while insert will cast it to float.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 13, 2020
@jbrockmendel jbrockmendel added API Design Reshaping Concat, Merge/Join, Stack/Unstack, Explode and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Nov 21, 2020
@jbrockmendel jbrockmendel mentioned this issue Nov 24, 2020
Merged
5 tasks
@jreback jreback added this to the 1.2 milestone Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
No open projects
Casting Consistency
Awaiting triage
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

BUG: NumericIndex.insert(0, False) casting to int jbrockmendel/pandas
2 participants
@jreback @jbrockmendel