Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: IntervalIndex.take without fill_value #37330

Merged
merged 17 commits into from
Oct 31, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Oct 22, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

IntervalIndex.take([0, 1, -1]) without explicitly passing fill_value should not fill the -1 as NA.

Fixing this allows us to use the base class take for IntervalIndex.take (the original motivation)

@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Interval Interval data type labels Oct 23, 2020
@jreback jreback added this to the 1.2 milestone Oct 23, 2020
@jreback
Copy link
Contributor

jreback commented Oct 23, 2020

bug fix right? can you add a whatsnew

@jbrockmendel
Copy link
Member Author

mothballing to clear the queue while i troubleshoot slow tests locally

@jbrockmendel jbrockmendel added the Mothballed Temporarily-closed PR the author plans to return to label Oct 28, 2020
@jbrockmendel jbrockmendel reopened this Oct 30, 2020
@jreback jreback merged commit 372a82e into pandas-dev:master Oct 31, 2020
@jbrockmendel jbrockmendel deleted the ref-share-take branch October 31, 2020 23:31
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
ukarroum pushed a commit to ukarroum/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel jbrockmendel removed the Mothballed Temporarily-closed PR the author plans to return to label Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Interval Interval data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants