PERF: faster dir() calls #37450
Merged
PERF: faster dir() calls #37450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
accessor_perf
branch
from
c0c3a97
to
0d38f73
Compare
jreback
reviewed
Oct 28, 2020
pandas/core/generic.py
Outdated
| for c in self._info_axis.unique(level=0)[:100] | ||
| if isinstance(c, str) and c.isidentifier() | ||
| } | ||
| additions = self._info_axis._dir_additions_for_owner |
There was a problem hiding this comment.
instead of adding all of this code, why can't you slap a cache_readonly here?
There was a problem hiding this comment.
That's not possible, because the axes (index/columns) can be changed. However, the axis labels are immutable, so it's safe to use cache_readonly there.
I've changed the PR to avoid the addition in child classes.
topper-123
force-pushed
the
accessor_perf
branch
from
94edc9f
to
5dd7294
Compare
topper-123
force-pushed
the
accessor_perf
branch
from
53d0ce2
to
3a3b674
Compare
|
thanks @topper-123 |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experience slow tab-completion in iPython, so I've optimized
dircalls in pandas, e.g.It does this by caching the output for the info axis, when the info axis may have string, and returning an empty set for info axes that cannot have strings (numeric indexes etc.)
The above didn't actually improve the subjective speed of tab completion for me, so the problem there probably is in Ipython, but the change in this PR can't hurt either.