API: consistently raise TypeError for invalid-typed fill_value #37733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
added
Error Reporting
|
Yea the back and forth is unfortunate, but I agree this seems more correct. Could use a whatsnew note |
…f-validate_fill_value
…f-validate_fill_value
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis makes us consistent about raising TypeError when passing a wrong-typed fill_value to e.g.
take. The downside is that we changedCategorical.takefrom TypeError to ValueError back in 1.1.0 #33660, so theres a bit of whiplash.The upside (besides this just being More Correct) is that we will be just about fully sharing setitem-like validator methods.