BUG: DataFrame.all(bool_only=True) inconsistency with object dtype #37799
Conversation
| assert self.ndim == 2 | ||
|
|
||
| new_blocks = [] | ||
| for i, ref_loc in enumerate(self.mgr_locs): |
There was a problem hiding this comment.
could be done as a list comprehension
jreback
added
API - Consistency
|
|
||
| Consistency of DataFrame Reductions | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| :meth:`DataFrame.any` and :meth:`DataFrame.all` with ``bool_only=True`` now |
There was a problem hiding this comment.
can you add this PR number here, and is there an actual issue? ping on green.
doc/source/whatsnew/v1.2.0.rst
Outdated
|
|
||
| *New behavior*: | ||
|
|
||
| .. code-block:: ipython |
There was a problem hiding this comment.
can you make this an ipython-block
| """ | ||
| assert self.ndim == 2 | ||
|
|
||
| new_blocks = [] |
There was a problem hiding this comment.
might be worth adding some unit tests for this (e.g. on a block that is empty, since column and multilple)
There was a problem hiding this comment.
good idea, was accidentally making a copy instead of a view!
|
ping |
|
|
||
| .. ipython:: python | ||
|
|
||
| In [5]: df.all(bool_only=True) |
There was a problem hiding this comment.
don't need the prompts (remove in followon / other PR)
There was a problem hiding this comment.
so remove the "In [5]: "? do i also remove the "Out [5]: "?
There was a problem hiding this comment.
yep i python will generate appropriately
| """ | ||
| assert self.ndim == 2 | ||
|
|
||
| new_blocks = [] |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffDiscussed on the dev call yesterday.