Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: Period constructor parses input twice #38312

Closed
arw2019 opened this issue Dec 5, 2020 · 1 comment · Fixed by #50149
Closed

PERF: Period constructor parses input twice #38312

arw2019 opened this issue Dec 5, 2020 · 1 comment · Fixed by #50149
Labels
Performance Memory or execution speed performance Period Period data type

Comments

@arw2019
Copy link
Member

arw2019 commented Dec 5, 2020

#38175 added correct handling of nanoseconds in the Period constructor but the code path as is parses the input twice. We should integrate the nanoseconds code into parse_time_string so this happens only once.

xref https://github.com/pandas-dev/pandas/pull/38175/files#r536100941

It might be worth adding a nanosecond Period constructor benchmark too.

@arw2019 arw2019 added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Dec 5, 2020
@jorisvandenbossche
Copy link
Member

@lithomas1 lithomas1 added Performance Memory or execution speed performance and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Feb 8, 2021
@lithomas1 lithomas1 added this to the 1.3 milestone Feb 8, 2021
@lithomas1 lithomas1 modified the milestones: 1.3, Contributions Welcome Apr 1, 2021
@mroeschke mroeschke added the Period Period data type label Aug 14, 2021
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance Period Period data type
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants