REGR: codecs.open() is always opened in text mode #39253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
twoertwein
commented
Jan 18, 2021
•
twoertwein
commented
- closes BUG: V1.2 DataFrame.to_csv() fails to write a file with codecs #39247
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
simonjayhawkins
added
the
IO Data
|
Thanks @twoertwein for the PR. can you add a release note to 1.2.1 for now. see #39239 (comment) |
doc/source/whatsnew/v1.2.1.rst
Outdated
| @@ -34,6 +34,7 @@ Fixed regressions | |||
| - Fixed regression in repr of float-like strings of an ``object`` dtype having trailing 0's truncated after the decimal (:issue:`38708`) | |||
| - Fixed regression that raised ``AttributeError`` with PyArrow versions [0.16.0, 1.0.0) (:issue:`38801`) | |||
| - Fixed regression in :func:`pandas.testing.assert_frame_equal` raising ``TypeError`` with ``check_like=True`` when :class:`Index` or columns have mixed dtype (:issue:`39168`) | |||
| - Fixed regression in :meth:`~DataFrame.to_csv` opening `codecs.StreamReaderWriter` in binary mode instead of in text mode (:issue:`39247`) | |||
There was a problem hiding this comment.
@jorisvandenbossche did a cleanup to re-order the regression fixes, #39246
can you move adjacent to the other IO regressions
There was a problem hiding this comment.
I moved it up to the other to_csv issue.
|
technically there are cases where |
|
thanks @twoertwein |
|
@meeseeksdev backport 1.2.x |
1 similar comment
|
@meeseeksdev backport 1.2.x |
|
Something went wrong ... Please have a look at my logs. |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 19, 2021
simonjayhawkins
pushed a commit
that referenced
this pull request
Jan 19, 2021
…#39271) Co-authored-by: Torsten Wörtwein <twoertwein@users.noreply.github.com>
nofarm3
pushed a commit
to nofarm3/pandas
that referenced
this pull request
Jan 21, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.