Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: csv_dir_path fixture check the existence of the dir instead of the file #39321

Open
fangchenli opened this issue Jan 21, 2021 · 0 comments
Open

TST: csv_dir_path fixture check the existence of the dir instead of the file #39321

fangchenli opened this issue Jan 21, 2021 · 0 comments
Labels
Build Library building on various platforms Testing pandas testing functions or related to the test suite

Comments

@fangchenli
Copy link
Member

Currently, all test date files are excluded in distribution. But we are using csv_dir_path fixture to check the existence of the directory instead of the test file itself. It caused many failures in #38852. I excluded the dir pandas/tests/io/parser/data in that PR. Maybe should check the file instead of the dir.
@fangchenli fangchenli added Bug Needs Triage Issue that has not been reviewed by a pandas team member Testing pandas testing functions or related to the test suite Build Library building on various platforms Needs Discussion Requires discussion from core team before further action and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 21, 2021
@mroeschke mroeschke removed the Needs Discussion Requires discussion from core team before further action label Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Library building on various platforms Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fangchenli @mroeschke