Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: Mypy failures with new numpy #39513

Closed
phofl opened this issue Jan 31, 2021 · 5 comments
Closed

TYP: Mypy failures with new numpy #39513

phofl opened this issue Jan 31, 2021 · 5 comments
Labels
Needs Discussion Requires discussion from core team before further action Typing type annotations, mypy/pyright type checking
Milestone

Comments

@phofl
Copy link
Member

phofl commented Jan 31, 2021

Mypy raises a lot of errors since the new numpy is available on conda-forge. What is the best approach here? Adding ignores for everything and fixing them step by step afterwards?

cc @simonjayhawkins

@phofl phofl added Bug Needs Triage Issue that has not been reviewed by a pandas team member Typing type annotations, mypy/pyright type checking and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 31, 2021
@simonjayhawkins
Copy link
Member

Adding ignores for everything and fixing them step by step afterwards?

#36092 is basically doing that (needs an update)

in the short term we should just pin numpy on ci and checks while we discuss.

another option could be remove any problematic type annotations from type signature, return types or variable annotations, they are likely incorrect in some cases which is why mypy is reporting errors

#39067 (comment)

@simonjayhawkins simonjayhawkins added the Needs Discussion Requires discussion from core team before further action label Feb 1, 2021
@simonjayhawkins simonjayhawkins added the Blocker Blocking issue or pull request for an upcoming release label Feb 1, 2021
@simonjayhawkins simonjayhawkins added this to the 1.2.2 milestone Feb 1, 2021
@simonjayhawkins
Copy link
Member

simonjayhawkins commented Feb 1, 2021

in the short term we should just pin numpy on ci and checks while we discuss.

#39526 has been backported to get ci green on 1.2.x but that PR changes environment.yaml.

I don't think we want to release with that change, so labelled as blocker for now.

@simonjayhawkins
Copy link
Member

moving to 1.2.3. will be merging #39641 before 1.2.2 release to avoid blocking.

@simonjayhawkins simonjayhawkins modified the milestones: 1.2.2, 1.2.3 Feb 7, 2021
@simonjayhawkins simonjayhawkins removed the Blocker Blocking issue or pull request for an upcoming release label Feb 26, 2021
@simonjayhawkins
Copy link
Member

in the short term we should just pin numpy on ci and checks while we discuss.

#39526 has been backported to get ci green on 1.2.x but that PR changes environment.yaml.

I don't think we want to release with that change, so labelled as blocker for now.

#39998 disables checking site packages (i.e. numpy and pytest) so no longer a blocker to 1.2.x releases, have removed the blocker tag, but will want to sort this before 1.3.

@simonjayhawkins simonjayhawkins modified the milestones: 1.2.3, 1.3 Feb 26, 2021
@simonjayhawkins
Copy link
Member

simonjayhawkins commented Mar 10, 2021

What is the best approach here? Adding ignores for everything and fixing them step by step afterwards?

merged that so will close this issue and open a new issue for the fix-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion Requires discussion from core team before further action Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

No branches or pull requests

2 participants