BUG/API: SeriesGroupBy reduction with numeric_only=True #41342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you can rebase this one |
|
haven't looked yet |
|
Rebased+green |
jreback
requested changes
May 17, 2021
| For DataFrameGroupBy we want it to be True (for backwards-compat). | ||
| """ | ||
| # GH#41291 | ||
| if numeric_only is lib.no_default: |
There was a problem hiding this comment.
are we deprecating the dataframe groupby behavior here?
There was a problem hiding this comment.
no, this is just a way of having the effective default be different for SeriesGroupBy vs DataFrameGroupBy
|
|
||
| def get_result(): | ||
| if method == "attr": |
There was a problem hiding this comment.
this is a super complicated test. can you try to split in followons.
doc/source/whatsnew/v1.3.0.rst
Outdated
| @@ -906,6 +906,7 @@ Groupby/resample/rolling | |||
| - Bug in :meth:`DataFrameGroupBy.__getitem__` with non-unique columns incorrectly returning a malformed :class:`SeriesGroupBy` instead of :class:`DataFrameGroupBy` (:issue:`41427`) | |||
| - Bug in :meth:`DataFrameGroupBy.transform` with non-unique columns incorrectly raising ``AttributeError`` (:issue:`41427`) | |||
| - Bug in :meth:`Resampler.apply` with non-unique columns incorrectly dropping duplicated columns (:issue:`41445`) | |||
| - Bug in :meth:`SeriesGroupBy` aggregations incorrectly returning empty :class:`Series` instead of raising ``TypeError`` on aggregations that are invalid for its dtype (:issue:`41342`) | |||
There was a problem hiding this comment.
can you give an example here that a user would understand
rhshadrach
requested changes
May 21, 2021
| @@ -91,7 +91,10 @@ def test_cython_agg_nothing_to_agg(): | |||
| frame = DataFrame({"a": np.random.randint(0, 5, 50), "b": ["foo", "bar"] * 25}) | |||
| msg = "No numeric types to aggregate" | |||
There was a problem hiding this comment.
I think this can be moved to the relevant section below
|
@jreback i think comments have been addressed; this is a blocker for fixing the analogous DataFrameGroupBy behavior |
jreback
approved these changes
May 26, 2021
…as into ref-numeric_only-sgb-2
|
Thanks @jbrockmendel |
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the SeriesGroupBy (easier) half of #41291:
numeric_only=True, change the default to False for SeriesGroupBy, leaving DataFrameGroupBy unaffected.