DEPR: Index.reindex with duplicate index #42568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Aug 5, 2021
pandas/core/indexes/base.py
Outdated
| @@ -3888,6 +3888,15 @@ def reindex( | |||
| if self.equals(target): | |||
| indexer = None | |||
| else: | |||
| if not self.is_unique: | |||
There was a problem hiding this comment.
don't you need to do this on L3912? e.g. raise if those conditions are tru first. also don't we know that its unique at this point?
There was a problem hiding this comment.
don't you need to do this on L3912? e.g. raise if those conditions are tru first
sure, will move this down
also don't we know that its unique at this point?
nope
jreback
reviewed
Aug 5, 2021
jreback
approved these changes
Aug 8, 2021
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed on this week's call.