BUG: Pass copy argument to expanddim constructor in concat. #42823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The one test failure in |
simonjayhawkins
added
Copy / view semantics
ExtensionArray
jreback
requested changes
Aug 3, 2021
|
ping when ready for merge |
jmcomie
force-pushed
the
jmcomie/gh42501
branch
from
6dfb8c3
to
ff6c88d
Compare
jreback
requested changes
Aug 7, 2021
Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
|
status here? |
Just about there. Can you look at the questions above in the review? |
answered! pls merge master as well and ping on green. |
jreback
approved these changes
Aug 11, 2021
|
thanks @jmcomie |
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 11, 2021
…nstructor in concat.
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Aug 11, 2021
…in concat. (#42984) Co-authored-by: Justin McOmie <justin.mcomie@gmail.com>
thanks for helping with the PR. I'm happy to contribute |
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the provided copy argument through to the DataFrame constructor when constructing a DataFrame from a Series iterable, as is done with the other DataFrame construction call in the get_result method.
The new test in frame/methods/test_astype.py is as provided by the author of the issue with minor changes.
@TomAugspurger this updates your test
extension/decimal/test_decimal.py:test_astype_dispatchesto expect both frame and series astype calls to retain the context.prec value. The prior failure was caused by the copying of the DataFrame, and that copy no longer occurs. The underlying issue with copy and the dtype is unaddressed here.