Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: Support fastparquet 0.7.1 #42919

Merged
merged 4 commits into from
Aug 8, 2021

Conversation

lithomas1
Copy link
Member

Also adds support for use_nullable_dtypes keyword. Technically, its not our enhancement its fastparquet's, so I think can backport. IMO, users shouldn't have to wait 6 months for 1.4 to get this new feature.

@lithomas1 lithomas1 added this to the 1.3.2 milestone Aug 6, 2021
@lithomas1 lithomas1 added Compat pandas objects compatability with Numpy or Python functions IO Parquet parquet, feather labels Aug 6, 2021
@lithomas1 lithomas1 requested a review from jreback August 6, 2021 18:40
parquet_kwargs["pandas_nulls"] = use_nullable_dtypes
else:
if use_nullable_dtypes:
raise ValueError(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this path tested?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback jreback merged commit e042219 into pandas-dev:master Aug 8, 2021
@jreback
Copy link
Contributor

jreback commented Aug 8, 2021

thanks @lithomas1

@jreback
Copy link
Contributor

jreback commented Aug 8, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 8, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.3.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 e0422193ddb8830f91d6c3ac7c2c11971cc390bb
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #42919: COMPAT: Support fastparquet 0.7.1'
  1. Push to a named branch :
git push YOURFORK 1.3.x:auto-backport-of-pr-42919-on-1.3.x
  1. Create a PR against branch 1.3.x, I would have named this PR:

"Backport PR #42919 on branch 1.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Aug 8, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.3.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 e0422193ddb8830f91d6c3ac7c2c11971cc390bb
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #42919: COMPAT: Support fastparquet 0.7.1'
  1. Push to a named branch :
git push YOURFORK 1.3.x:auto-backport-of-pr-42919-on-1.3.x
  1. Create a PR against branch 1.3.x, I would have named this PR:

"Backport PR #42919 on branch 1.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche
Copy link
Member

As I mentioned (lately) on the issue, I am not in favor of enabling the use_nullable_dtypes keyword for the fastparquet engine if we don't guarantee a consistent behaviour (or at least I wouldn't backport that part, so we have a bit more time to flesh out the behaviour).

@simonjayhawkins
Copy link
Member

hmm, we have the change note in 1.3.2 whatsnew.

can we revert this from master, reopen the PR to continue the discussion. and have two separate PRs if needed to avoid a partial backport.

@lithomas1 lithomas1 deleted the unpin-fastparquet branch August 9, 2021 17:05
@lithomas1
Copy link
Member Author

Happy to talk it out. I think we can backport something that just turns of all the nullable dtypes for now until we get this sorted out. Will send PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions IO Parquet parquet, feather
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Fastparquet upgrade broke CI
4 participants