BUG: fix string truncation for astype(str) #4437
Conversation
ghost
assigned 
| values = com._astype_nansafe(self.values, dtype) | ||
| else: | ||
| values = self.values |
There was a problem hiding this comment.
so str hits this here, but should be then changed to object dtype?
There was a problem hiding this comment.
yep that's right. my mistake. one issue now is that if you pass x.astype(str) and x is not already a string then you'll get back an object array....
should this instead do something like x.map(dtype.type)? that would actually convert to string...but it would pretty slow...i guess object arrays are slow anyway tho
There was a problem hiding this comment.
I am not sure, you can certainly take the str in the astype and do it differently if needed (that object)
but make sure its not actually converting to str
I think I do a translation on str,np.string_ in parsers.pyx somewhere (so can pass in a dtype like that)
do the same sort of thing here
|
@jreback ok 2 merge? |
|
looks ok |
BUG: fix string truncation for astype(str)
closes #4405.