Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: add option for checking attrs in testing #44768

Open
jreback opened this issue Dec 5, 2021 · 1 comment
Open

TST: add option for checking attrs in testing #44768

jreback opened this issue Dec 5, 2021 · 1 comment
Labels
Enhancement metadata _metadata, .attrs Testing pandas testing functions or related to the test suite

Comments

@jreback
Copy link
Contributor

jreback commented Dec 5, 2021

should enhance assert_frame_equal/assert_series_equal to allow a check for attrs matching. I believe we can default this to true now.
@jreback jreback added Enhancement Testing pandas testing functions or related to the test suite labels Dec 5, 2021
@jreback jreback added this to the 1.4 milestone Dec 5, 2021
@lithomas1 lithomas1 added the metadata _metadata, .attrs label Dec 9, 2021
@jreback jreback modified the milestones: 1.4, 1.5 Dec 31, 2021
@mroeschke mroeschke removed this from the 1.5 milestone Aug 15, 2022
@jbrockmendel
Copy link
Member

i lean 1) towards making these more strict and 2) against adding more keywords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement metadata _metadata, .attrs Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jreback @jbrockmendel @mroeschke @lithomas1