Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: GroupBy.cummin altering nullable arrays inplace #46220

Merged
merged 3 commits into from
Mar 5, 2022
Merged

BUG: GroupBy.cummin altering nullable arrays inplace #46220

merged 3 commits into from
Mar 5, 2022

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Mar 4, 2022 •
edited
Loading

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

mroeschke
mroeschke reviewed Mar 4, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs a whatsnew?

@mroeschke mroeschke added Groupby Reduction Operations sum, mean, min, max, etc. labels Mar 4, 2022
@mroeschke mroeschke added this to the 1.5 milestone Mar 4, 2022
rhshadrach
rhshadrach approved these changes Mar 5, 2022
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit 92284c5 into pandas-dev:main Mar 5, 2022
@jbrockmendel jbrockmendel deleted the ref-result_mask branch March 5, 2022 21:09
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@jbrockmendel @yehoshuadimarsky
BUG: GroupBy.cummin altering nullable arrays inplace (pandas-dev#46220)
d20c883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Groupby Reduction Operations sum, mean, min, max, etc.
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbrockmendel @mroeschke @rhshadrach @jreback