You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the signature for constructing most DateOffset is (n, **kwds).
Optional ags are then read using get(key) from the kwds and required args using [key]. This is fine, but it leaves what was extracted from kwds still in kwds leading to a redundant str or repr:
Taking a look at how kwds is used (e.g for copy) by the base class, DateOffset, it will be easier to cleanup how repr works rather than changing what is left in kwds.
Currently the signature for constructing most
DateOffset
is(n, **kwds)
.Optional ags are then read using
get(key)
from thekwds
and required args using[key]
. This is fine, but it leaves what was extracted fromkwds
still inkwds
leading to a redundantstr
orrepr
:I would recommend using
pop
instead ofget
and usingdel
after reading required values.Thoughts?
The text was updated successfully, but these errors were encountered: