TYP: read_sas #47410
Merged
TYP: read_sas #47410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Jun 18, 2022
|
Does this need documentation because we’re breaking the API or do we consider it internal with no guarantees? |
If we want this change @jreback (I certainly would like it from a typing perspective), I think it should have a whatsnew. Otherwise, I'm happy to keep |
|
i think it's fine just add a note on the very slight api change |
mroeschke
added
IO SAS
mroeschke
reviewed
Jun 21, 2022
jreback
approved these changes
Jun 24, 2022
|
Thanks @twoertwein |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* TYP: read_sas * make __next__ compatibel with empty datafram * df -> da * whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.