Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add inplace argument for df.join() #47458

Closed
charizard-knows opened this issue Jun 22, 2022 · 1 comment
Closed

ENH: Add inplace argument for df.join() #47458

charizard-knows opened this issue Jun 22, 2022 · 1 comment
Labels
Closing Candidate May be closeable, needs more eyeballs Enhancement Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Comments

@charizard-knows
Copy link

charizard-knows commented Jun 22, 2022

Is your feature request related to a problem?

Adding inplace argument for df.join() will be more in line with Pandas environment.

Describe the solution you'd like

Add an inplace parameter in df.join() so that it becomes
df.join(obj,.... inplace=False)

API breaking implications

None

Describe alternatives you've considered

Alternative is to assign the new df in place of old df by doing
df = df.join(other_df)

@charizard-knows charizard-knows added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 22, 2022
@phofl
Copy link
Member

phofl commented Jun 22, 2022

HI thanks for your report. We are currently discussing deprecating inplace. So this is unlikely to happen.

@phofl phofl added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Closing Candidate May be closeable, needs more eyeballs and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 22, 2022
@charizard-knows charizard-knows closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closing Candidate May be closeable, needs more eyeballs Enhancement Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

No branches or pull requests

2 participants