Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: dont infer dtype for object-dtype groupby reductions #51205

Merged
merged 4 commits into from
Feb 10, 2023
Merged

API: dont infer dtype for object-dtype groupby reductions #51205

merged 4 commits into from
Feb 10, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

rhshadrach
rhshadrach approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I think we should also do this with Series / DataFrame ops (e.g. DataFrame.mean returns float on object input).

@rhshadrach rhshadrach added Groupby Dtype Conversions Unexpected or buggy dtype conversions API - Consistency Internal Consistency of API/Behavior labels Feb 9, 2023
@phofl phofl added this to the 2.0 milestone Feb 9, 2023
@phofl
Copy link
Member

phofl commented Feb 9, 2023

needs a rebase

@mroeschke mroeschke merged commit 9eec5bf into pandas-dev:main Feb 10, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the api-agg_py_fallback branch February 10, 2023 18:10
phofl pushed a commit to phofl/pandas that referenced this pull request Feb 10, 2023
@jbrockmendel @phofl
API: dont infer dtype for object-dtype groupby reductions (pandas-dev…
d625904 
…#51205)

* API: dont infer dtype for object-dtype groupby reductions

* GH ref
@rhshadrach rhshadrach mentioned this pull request Feb 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
API - Consistency Internal Consistency of API/Behavior Dtype Conversions Unexpected or buggy dtype conversions Groupby
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbrockmendel @phofl @mroeschke @rhshadrach