BUG: Timestamp.round overflows #51494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Bug
Timedelta
mroeschke
reviewed
Feb 23, 2023
doc/source/whatsnew/v2.0.0.rst
Outdated
| @@ -1210,12 +1210,14 @@ Datetimelike | |||
| - Bug in :func:`to_datetime` with both ``unit`` and ``origin`` specified returning incorrect results (:issue:`42624`) | |||
| - Bug in :meth:`GroupBy.quantile` with datetime or timedelta dtypes giving incorrect results for groups containing ``NaT`` (:issue:`51373`) | |||
| - Bug in :meth:`Groupby.quantile` incorrectly raising with :class:`PeriodDtype` or :class:`DatetimeTZDtype` (:issue:`51373`) | |||
| - Bug in :meth:`Timestamp.round` with values close to the implementation bounds returning incorrect results instead of raising ``OutOfBoundsDatetime`` (:issue:`51494`) | |||
There was a problem hiding this comment.
Does this impact the new non-nano feature? Otherwise might be good for 2.1 instead
There was a problem hiding this comment.
Nothing specific to non-nano here, this will affect any reso
There was a problem hiding this comment.
Got it. I think it may be safer to not backport for now and move to 2.1 unless you have a strong opinion for this to be in 2.0
mroeschke
reviewed
Feb 23, 2023
|
rebased+greenish |
|
Note moved, greenish |
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Ran the hypothesis tests with max_examples=10**6