Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: axis=1 in DataFrame.window, resample #51778

Closed
jbrockmendel opened this issue Mar 4, 2023 · 7 comments · Fixed by #51901
Closed

DEPR: axis=1 in DataFrame.window, resample #51778

jbrockmendel opened this issue Mar 4, 2023 · 7 comments · Fixed by #51901
Assignees
@dannyi96
Labels
Deprecate Functionality to remove in pandas Resample resample method Window rolling, ewma, expanding

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Mar 4, 2023 •
edited
Loading

xref #51203 we've deprecated groupby with axis=1 bc under the hood it does a transpose anyway, so might as well tell users to do that directly. resample and window do the same thing. Let's deprecate those too.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member Deprecate Functionality to remove in pandas Needs Discussion Requires discussion from core team before further action and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Mar 4, 2023
@rhshadrach rhshadrach added Resample resample method Window rolling, ewma, expanding and removed Needs Discussion Requires discussion from core team before further action labels Mar 4, 2023
@rhshadrach
Copy link
Member

+1

@dannyi96
Copy link
Contributor

dannyi96 commented Mar 4, 2023

Can I attempt to work on this if possible / not started on by anyone else ?
@jbrockmendel @rhshadrach

@jbrockmendel
Copy link
Member Author

Wait until a consensus develops

@mroeschke
Copy link
Member

+1

1 similar comment
@jreback
Copy link
Contributor

jreback commented Mar 6, 2023

+1

@phofl
Copy link
Member

phofl commented Mar 6, 2023

Sounds good to me

@dannyi96
Copy link
Contributor

dannyi96 commented Mar 9, 2023

take

@dannyi96 dannyi96 mentioned this issue Mar 11, 2023
Merged
5 tasks
@topper-123 topper-123 mentioned this issue Mar 12, 2023
Merged
5 tasks
@johentsch johentsch mentioned this issue Nov 28, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dannyi96 dannyi96

Labels
Deprecate Functionality to remove in pandas Resample resample method Window rolling, ewma, expanding
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DEPR: DataFrame.resample axis parameter dannyi96/pandas
6 participants
@jreback @jbrockmendel @mroeschke @dannyi96 @rhshadrach @phofl