ERR: Raise ValueError when non-default index is given for orc format #51828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Mar 7, 2023
pandas/io/orc.py
Outdated
| # validate that we have only a default index | ||
| # raise on anything else as we don't serialize the index | ||
|
|
||
| if not df.index.equals(RangeIndex.from_range(range(len(df)))): |
There was a problem hiding this comment.
Might be clearer to use pandas.core.indexes.api.default_index
Just confirming, they are dropped without a warning/exception from pyarrow? |
|
Yes they are just gone when roundtripping |
mroeschke
reviewed
Mar 8, 2023
mroeschke
reviewed
Mar 8, 2023
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
# Conflicts: # pandas/io/orc.py
mroeschke
approved these changes
Mar 14, 2023
|
Thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.orc can't handle indexes right now (they are dropped), so we should raise like we did in feather