BUG: __from_arrow__ doesn't accept pyarrow null arrays for numeric ma… #52223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
added
Bug
NA - MaskedArrays
mroeschke
reviewed
Mar 27, 2023
5 tasks
mroeschke
reviewed
Apr 3, 2023
phofl
reviewed
Apr 4, 2023
| else: | ||
| # pyarrow.ChunkedArray | ||
| chunks = array.chunks | ||
| length = array.length | ||
|
|
||
| if pyarrow.types.is_null(array.type): |
There was a problem hiding this comment.
I'd move this up before the isinstance checks
There was a problem hiding this comment.
I think the isinstance checks are necessary since the way we find length depends on the type of pyarrow array(regular array uses len, while chunkedarray needs length).
I could be missing something again, though.
There was a problem hiding this comment.
I assumed that array would have length as well, but that's not the case. So looks good
|
Looks like a merge conflict otherwise LGTM |
phofl
approved these changes
Apr 7, 2023
|
Thanks for the reviews all, going to merge this to unblock myself. |
|
I'd rather not create chains that we have to backport. If fixes aren't totally trivial we should probably hold off? |
|
Seems reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sked types
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.