Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: EA.interpolate #53659

Merged
merged 12 commits into from
Jun 28, 2023
Merged

ENH: EA.interpolate #53659

merged 12 commits into from
Jun 28, 2023

Conversation

jbrockmendel
Copy link
Member

Fixed some incorrect type annotations, de-duplicate some code paths.

Copy link
Contributor

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just looked at _typing.py. Introducing InterpolateOptions is something we should pull over to pandas-stubs . Created pandas-dev/pandas-stubs#732 for that

@mroeschke mroeschke added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate ExtensionArray Extending pandas with custom dtypes or arrays. labels Jun 14, 2023
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could use a whatsnew note in 2.1 that EA.interpolate was added

@jbrockmendel
Copy link
Member Author

Looks good. Could use a whatsnew note in 2.1 that EA.interpolate was added

updated+green

@mroeschke mroeschke added this to the 2.1 milestone Jun 28, 2023
@mroeschke mroeschke merged commit c96544e into pandas-dev:main Jun 28, 2023
34 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the enh-interp branch June 28, 2023 21:53
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* ENH: EA.interpolate

* update code check

* update docstring to appease code check

* inplace->copy

* whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: .interpolate() with EA Dtypes
3 participants