Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix string formatting #53855

Merged
merged 16 commits into from Jun 26, 2023
Merged

Conversation

yuanx749
Copy link
Contributor

@yuanx749 yuanx749 commented Jun 26, 2023

Take over pr #52883.

@mroeschke mroeschke added this to the 2.0.3 milestone Jun 26, 2023
@mroeschke mroeschke added the Output-Formatting __repr__ of pandas objects, to_string label Jun 26, 2023
@mroeschke mroeschke merged commit 62fb061 into pandas-dev:main Jun 26, 2023
37 checks passed
@mroeschke
Copy link
Member

Thanks @yuanx749

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 26, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 62fb0617137a32914716ae5a5c44b699fef82676
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #53855: BUG: Fix string formatting'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-53855-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #53855 on branch 2.0.x (BUG: Fix string formatting)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@yuanx749 yuanx749 deleted the fix_string_formatting branch June 26, 2023 17:25
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Jun 26, 2023
mroeschke added a commit that referenced this pull request Jun 26, 2023
* Backport PR #53855: BUG: Fix string formatting

* Remove note

---------

Co-authored-by: Xiao Yuan <yuanx749@gmail.com>
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* fixed string formatting bug

* updating doc

* add tests

* change whatsnew

* Update doc/source/whatsnew/v2.0.1.rst

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

* Update v2.0.1.rst

* Update v2.0.1.rst

* change whatsnew

* Update pandas/tests/io/formats/test_format.py

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>

* Fix bug with smaller change

---------

Co-authored-by: Rithik Reddy <rithik.g.reddy@vanderbilt.edu>
Co-authored-by: reddyrg1 <59897313+reddyrg1@users.noreply.github.com>
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame.to_string() creates extra space for string dtypes in pandas >=2.0
3 participants